mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <ben...@yandex-team.ru>
Subject Re: Review Request 62212: Send TASK_STARTING from the built-in executors.
Date Fri, 29 Sep 2017 19:47:31 GMT


> On Sept. 13, 2017, 5:29 p.m., Andrei Budnik wrote:
> > src/launcher/default_executor.cpp
> > Line 326 (original), 332 (patched)
> > <https://reviews.apache.org/r/62212/diff/2/?file=1820838#file1820838line332>
> >
> >     Should we update the comment above?

I think the comment is still correct.


> On Sept. 13, 2017, 5:29 p.m., Andrei Budnik wrote:
> > src/launcher/default_executor.cpp
> > Lines 412 (patched)
> > <https://reviews.apache.org/r/62212/diff/2/?file=1820838#file1820838line412>
> >
> >     Adding default constructor for `DefaultExecutor::Container` will help us to
get rid of repeating `None()` and `false`.

I'm not sure about adding a function that will be called only once.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185310
-----------------------------------------------------------


On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0

>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message