mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.
Date Fri, 29 Sep 2017 17:44:38 GMT


> On Sept. 26, 2017, 10:11 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some Mesos tests failed.
> > 
> > Reviews applied: `['62475', '62476', '62477', '62581', '62478', '62479', '62480',
'62481', '62507', '62531', '62554']`
> > 
> > Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62554
> > 
> > Relevant logs:
> > 
> > - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62554/logs/mesos-tests-stdout.log):
> > 
> > ```
> > [       OK ] FilesTest.DetachTest (5 ms)
> > [ RUN      ] FilesTest.ReadTest
> > [       OK ] FilesTest.ReadTest (292 ms)
> > [ RUN      ] FilesTest.DownloadTest
> > [       OK ] FilesTest.DownloadTest (126 ms)
> > [ RUN      ] FilesTest.DebugTest
> > [       OK ] FilesTest.DebugTest (123 ms)
> > [ RUN      ] FilesTest.AuthenticationTest
> > [       OK ] FilesTest.AuthenticationTest (99 ms)
> > [----------] 6 tests from FilesTest (807 ms total)
> > 
> > [----------] 3 tests from GarbageCollectorTest
> > [ RUN      ] GarbageCollectorTest.Schedule
> > [       OK ] GarbageCollectorTest.Schedule (123 ms)
> > [ RUN      ] GarbageCollectorTest.Unschedule
> > [       OK ] GarbageCollectorTest.Unschedule (36 ms)
> > [ RUN      ] GarbageCollectorTest.Prune
> > [       OK ] GarbageCollectorTest.Prune (37 ms)
> > [----------] 3 tests from GarbageCollectorTest (299 ms total)
> > 
> > [----------] 5 tests from GarbageCollectorIntegrationTest
> > [ RUN      ] GarbageCollectorIntegrationTest.Restart
> > 
> > C:\mesos\mesos\src\tests\gc_tests.cpp(332): ERROR: this mock object (used in test
GarbageCollectorIntegrationTest.Restart) should be deleted but never is. Its address is @000000752FB59910.
> > C:\mesos\mesos\src\tests\containerizer.cpp(414): ERROR: this mock object (used in
test GarbageCollectorIntegrationTest.Restart) should be deleted but never is. Its address
is @000000752FB59DE0.
> > C:\mesos\mesos\src\tests\gc_tests.cpp(317): ERROR: this mock object (used in test
GarbageCollectorIntegrationTest.Restart) should be deleted but never is. Its address is @000000752FB5B370.
> > C:\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in
test GarbageCollectorIntegrationTest.Restart) should be deleted but never is. Its address
is @000001E405FCC520.
> > C:\mesos\mesos\3rdparty\libprocess\include\process/gmock.hpp(235): ERROR: this mock
object (used in test GarbageCollectorIntegrationTest.Restart) should be deleted but never
is. Its address is @000001E406498898.
> > ERROR: 5 leaked mock objects found at program exit.
> > ```
> > 
> > - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62554/logs/mesos-tests-stderr.log):
> > 
> > ```
> >   scalar {
> >     value: 1024
> >   }
> > }
> > resources {
> >   name: "disk"
> >   type: SCALAR
> >   scalar {
> >     value: 1024
> >   }
> > }
> > resources {
> >   name: "ports"
> >   type: RANGES
> >   ranges {
> >     range {
> >       begin: 31000
> >       end: 32000
> >     }
> >   }
> > }
> > checkpoint: true
> > port: 56595
> > 
> > ------------------------------------------------------------
> > To remedy this do as follows:
> > Step 1: rm -f C:\Users\mesos\AppData\Local\Temp\2\ppnykI\meta\slaves\latest
> >         This ensures agent doesn't recover old live executors.
> > Step 2: Restart the agent.
> > ```
> 
> Vinod Kone wrote:
>     this seems problematic, though i can't easily tell which test is breaking. GarbageCollectorIntegrationTest.Restart?
Anand, can you please triage this?

We need to add this for the test to pass on windows similar to what we did for the other new
tests that involve restarting an agent again

```cpp
// TODO(andschwa): Enable this when MESOS-7604 is fixed.
```


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62554/#review186337
-----------------------------------------------------------


On Sept. 26, 2017, 8:30 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62554/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 8:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7448
>     https://issues.apache.org/jira/browse/MESOS-7448
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces two master options `registry_max_gone_agent_age`
> (age based) and `registry_max_gone_agent_count` (count based) for
> GC'ing the list of gone agents in the registry.
> 
> Review: https://reviews.apache.org/r/62554
> 
> 
> Diffs
> -----
> 
>   src/master/flags.cpp fa6d274cb52448269a8108ffdc5f07bad8b222f2 
>   src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113 
>   src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 
>   src/tests/master_tests.cpp 98908c00c2d5bfd08122fd317a2ce95332d9583d 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
>   src/tests/registrar_tests.cpp b5fc45887e25345d49feb4975f6256cfd7b0fe55 
> 
> 
> Diff: https://reviews.apache.org/r/62554/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message