mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 62214: Added JavaScript linter.
Date Fri, 29 Sep 2017 13:28:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
-----------------------------------------------------------

(Updated Sept. 29, 2017, 1:28 p.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
-------

Added comments to bootstrap script and changed nodeenv version to not have `OSError: [Errno
17] File exists` errors.


Bugs: MESOS-7924
    https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description
-------

This linter runs when changes on a JavaScript file are being committed.
The linter used is ESLint with a configuration based on our current JS
code base. The linter and its dependencies (i.e. Node.js) are installed
in a environment using Virtualenv and then Nodeenv.


Diffs (updated)
-----

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 


Diff: https://reviews.apache.org/r/62214/diff/4/

Changes: https://reviews.apache.org/r/62214/diff/3-4/


Testing
-------

Following this commit, I have tried to commit a change on a JavaScript file and checked that
ESLinter was correctly running.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message