mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 62554: Added the ability to prune the gone agent list from the registry.
Date Tue, 26 Sep 2017 01:02:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62554/#review186189
-----------------------------------------------------------




src/master/flags.cpp
Lines 610-629 (patched)
<https://reviews.apache.org/r/62554/#comment262649>

    Can we just reuse the `registry_max_agent_count` and `registry_max_agent_age` flags/values?
They seem generic enough and used for partitioned and removed agents already.


- Vinod Kone


On Sept. 25, 2017, 11:39 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62554/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 11:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7448
>     https://issues.apache.org/jira/browse/MESOS-7448
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces two master options `registry_max_gone_agent_age`
> (age based) and `registry_max_gone_agent_count` (count based) for
> GC'ing the list of gone agents in the registry.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 725680b1e5f1fb9ca87ec5130d0eff72309432ae 
>   src/master/flags.hpp edda71af41a8d199bb24b84487300e9c85b12fec 
>   src/master/flags.cpp fa6d274cb52448269a8108ffdc5f07bad8b222f2 
>   src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113 
>   src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 
>   src/tests/master_tests.cpp 98908c00c2d5bfd08122fd317a2ce95332d9583d 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
>   src/tests/registrar_tests.cpp b5fc45887e25345d49feb4975f6256cfd7b0fe55 
> 
> 
> Diff: https://reviews.apache.org/r/62554/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message