mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62518: Fixed default executor handling of nested container status.
Date Mon, 25 Sep 2017 16:51:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62518/#review186139
-----------------------------------------------------------



PASS: Mesos patch 62518 was successfully built and tested.

Reviews applied: `['62518']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62518

- Mesos Reviewbot Windows


On Sept. 25, 2017, 3:21 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62518/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 3:21 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default executor was not handling a missing nested container
> exit status correctly. It was assuming the protobuf accessor was
> returning an Option rather than explicitly checking whether the
> `exit_status` field was present in the message.
> 
> Added the explicit check for the `exit_status` field, and always
> propagated an appropriate message into the status update, even
> when the `exit_status` is absent. Added some documentation of
> the `exit_status` field to the protobuf definition files.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae 
>   include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096 
>   src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 
> 
> 
> Diff: https://reviews.apache.org/r/62518/diff/4/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message