mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 60088: CLI: Added 'master' key as an acceptable key in config.toml.
Date Mon, 25 Sep 2017 14:03:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60088/
-----------------------------------------------------------

(Updated Sept. 25, 2017, 2:03 p.m.)


Review request for mesos and Kevin Klues.


Changes
-------

Updated `master()` function.


Summary (updated)
-----------------

CLI: Added 'master' key as an acceptable key in config.toml.


Bugs: MESOS-7284
    https://issues.apache.org/jira/browse/MESOS-7284


Repository: mesos


Description (updated)
-------

This key is a field that has to be composed of
an `address` or `zookeeper` field, but not both.


Diffs (updated)
-----

  src/python/cli_new/README.md c5475c7f4632fde5303ed1c901918d9088eac660 
  src/python/cli_new/lib/cli/config.py 36a32f94bb12a033705b20f3c91d8bba972ba6c5 
  src/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492 


Diff: https://reviews.apache.org/r/60088/diff/6/

Changes: https://reviews.apache.org/r/60088/diff/5-6/


Testing
-------

Tested manually, PEP8 and Pylint used to make sure that the code style is correct.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message