mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1 Master API.
Date Fri, 22 Sep 2017 20:23:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/#review186012
-----------------------------------------------------------




include/mesos/master/master.proto
Lines 202 (patched)
<https://reviews.apache.org/r/62475/#comment262371>

    s/failed/failed and it is never coming back
    
    Add a line that reservations/volumes would no longer be accessible. Add an example around
a auto scaling group or a cloud instance.



include/mesos/master/master.proto
Lines 207 (patched)
<https://reviews.apache.org/r/62475/#comment262374>

    Also add that the agent would be shut down in this case when it tries to reregister when
the partition heals.



include/mesos/master/master.proto
Lines 209 (patched)
<https://reviews.apache.org/r/62475/#comment262370>

    Consider making it `repeated`.


- Anand Mazumdar


On Sept. 21, 2017, 9:38 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62475/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 9:38 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7443
>     https://issues.apache.org/jira/browse/MESOS-7443
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces the `MARK_AGENT_GONE` call that can be
> used by operators to assert that a given agent has failed. It
> is specially useful for stateful frameworks to ascertain whether
> its safe to move the workload to a new agent.
> 
> Review: https://reviews.apache.org/r/62475
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415 
>   include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49 
> 
> 
> Diff: https://reviews.apache.org/r/62475/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message