mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 61212: Added CLI utility functions to check IPs and ports.
Date Fri, 22 Sep 2017 12:34:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61212/#review185977
-----------------------------------------------------------




src/python/cli_new/lib/cli/util.py
Lines 158 (patched)
<https://reviews.apache.org/r/61212/#comment262324>

    s/check/verify/s
    
    Also, let's leave `name` out of this as a parameter and instead prepend that information
by wrapping the error string propogated up.



src/python/cli_new/lib/cli/util.py
Lines 179 (patched)
<https://reviews.apache.org/r/61212/#comment262326>

    get rid of printing host/name here.



src/python/cli_new/lib/cli/util.py
Lines 189 (patched)
<https://reviews.apache.org/r/61212/#comment262325>

    use ip instead of host/name.



src/python/cli_new/lib/cli/util.py
Lines 193 (patched)
<https://reviews.apache.org/r/61212/#comment262329>

    Let's make sure to call this in a loop over all possible masters at the call site. Eventually
we will have an `Agent` class that takes a `Master` object that know how to do this looping
for us.



src/python/cli_new/lib/cli/util.py
Lines 217 (patched)
<https://reviews.apache.org/r/61212/#comment262330>

    This seems weird. We should just pluck out the first master from the config (what about
the other masters in that list?). We should build a `Master` abstraction that takes the config
at construction and knows how to loop over all masters when performing any of its operations.



src/python/cli_new/lib/cli/util.py
Lines 218 (patched)
<https://reviews.apache.org/r/61212/#comment262327>

    This should be wrapped in a try. If an error is raised, we can wrap the error produced
and print that it ws the result of trying to verify the address elements from a 'master' node.


- Kevin Klues


On Sept. 4, 2017, 2:46 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61212/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2017, 2:46 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7840
>     https://issues.apache.org/jira/browse/MESOS-7840
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used by future plugins.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/util.py 7371f83543ed527bea8dbf2fe4e20d92ef8e4492 
> 
> 
> Diff: https://reviews.apache.org/r/61212/diff/3/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message