mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62353: Added a master-registry backed resource provider manager registry.
Date Thu, 21 Sep 2017 14:40:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62353/#review185890
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['62282', '58048', '62158', '62438', '62439', '61183', '61528', '62353']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 'argument': conversion from
'double' to 'float', possible loss of data [C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 'argument': truncation from
'double' to 'float' [C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\common\http_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(445): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\common\http_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\common\recordio_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(445): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\common\recordio_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\common\type_utils_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(445): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\common\type_utils_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\containerizer\docker_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(445): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\containerizer\docker_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(445): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\src\master/master.hpp(2033): warning C4244: 'return': conversion from 'unsigned
__int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\tests\common\type_utils_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\src\master/master.hpp(2033): warning C4244: 'return': conversion from 'unsigned
__int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\mesos\src\master/master.hpp(2033): warning C4244: 'return': conversion from 'unsigned
__int64' to 'double', possible loss of data (compiling source file C:\mesos\mesos\src\tests\containerizer\docker_tests.cpp)
[C:\mesos\src\tests\mesos-tests.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
(Link target) -> 
  resource_provider_manager_tests.obj : error LNK2019: unresolved external symbol "public:
__cdecl mesos::state::LevelDBStorage::LevelDBStorage(class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > const &)" (??0LevelDBStorage@state@mesos@@QEAA@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
referenced in function "private: virtual void __cdecl mesos::internal::tests::ResourceProviderRegistrarTest_MasterRegistrar_Test::TestBody(void)"
(?TestBody@ResourceProviderRegistrarTest_MasterRegistrar_Test@tests@internal@mesos@@EEAAXXZ)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  mesos.lib(registrar.cpp.obj) : error LNK2001: unresolved external symbol "public: __cdecl
mesos::state::LevelDBStorage::LevelDBStorage(class std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &)" (??0LevelDBStorage@state@mesos@@QEAA@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  resource_provider_manager_tests.obj : error LNK2019: unresolved external symbol "public:
virtual __cdecl mesos::state::LevelDBStorage::~LevelDBStorage(void)" (??1LevelDBStorage@state@mesos@@UEAA@XZ)
referenced in function "private: virtual void __cdecl mesos::internal::tests::ResourceProviderRegistrarTest_MasterRegistrar_Test::TestBody(void)"
(?TestBody@ResourceProviderRegistrarTest_MasterRegistrar_Test@tests@internal@mesos@@EEAAXXZ)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  mesos.lib(registrar.cpp.obj) : error LNK2001: unresolved external symbol "public: virtual
__cdecl mesos::state::LevelDBStorage::~LevelDBStorage(void)" (??1LevelDBStorage@state@mesos@@UEAA@XZ)
[C:\mesos\src\tests\mesos-tests.vcxproj]
  C:\mesos\src\mesos-tests.exe : fatal error LNK1120: 2 unresolved externals [C:\mesos\src\tests\mesos-tests.vcxproj]

    327 Warning(s)
    5 Error(s)

Time Elapsed 01:03:58.99
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_a7e3c.dir\Debug\cmTC_a7e3c.tlog\".

InitializeBuildStatus:

  Creating "cmTC_a7e3c.dir\Debug\cmTC_a7e3c.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_a7e3c.dir\Debug\" /Fd"cmTC_a7e3c.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_a7e3c.dir\Debug\" /Fd"cmTC_a7e3c.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_a7e3c.exe" /INCREMENTAL /NOLOGO
kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed
/DEBUG /PDB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_a7e3c.pdb" /SUBSYSTEM:CONSOLE /TLBID:1
/DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_a7e3c.lib" /MACHINE:X64
 /machine:x64 cmTC_a7e3c.dir\Debug\src.obj

  cmTC_a7e3c.vcxproj -> C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_a7e3c.exe

  cmTC_a7e3c.vcxproj -> C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_a7e3c.pdb (Full PDB)

FinalizeBuildStatus:

  Deleting file "cmTC_a7e3c.dir\Debug\cmTC_a7e3c.tlog\unsuccessfulbuild".

  Touching "cmTC_a7e3c.dir\Debug\cmTC_a7e3c.tlog\cmTC_a7e3c.lastbuildstate".

Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_a7e3c.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:01.98


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62353/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_9c702.dir\Debug\".

  Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_9c702.dir\Debug\cmTC_9c702.tlog\".

InitializeBuildStatus:

  Creating "cmTC_9c702.dir\Debug\cmTC_9c702.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_9c702.dir\Debug\" /Fd"cmTC_9c702.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_9c702.dir\Debug\" /Fd"cmTC_9c702.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_9c702.vcxproj]

Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_9c702.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"C:\mesos\CMakeFiles\CMakeTmp\cmTC_9c702.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_9c702.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:01.68



```

- Mesos Reviewbot Windows


On Sept. 21, 2017, 3:59 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62353/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 3:59 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds an implementation of the resource provider registrar
> backed by the master's registrar. With that it becomes possible to
> persist resource provider manager state in a single master registrar,
> but use the narrowly defined resource provider registry.
> 
> 
> Diffs
> -----
> 
>   src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a 
>   src/resource_provider/registrar.hpp PRE-CREATION 
>   src/resource_provider/registrar.cpp PRE-CREATION 
>   src/tests/resource_provider_manager_tests.cpp 3bc56b51526e9dd188423f7349e74246c3295c77

> 
> 
> Diff: https://reviews.apache.org/r/62353/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message