mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 62447: Revert usage of `-isystem` flag.
Date Thu, 21 Sep 2017 08:42:57 GMT


> On Sept. 20, 2017, 7:29 p.m., Andrew Schwartzmeyer wrote:
> > It looks like the problem is `-isystem /usr/include` according to the upstream bug
report, but all of these paths should be of the form (just looking over them) `-isystem /usr/include/foo`
or `-isystem /blah/foo/include` and not just raw `/usr/include`. Which is the problematic
one?

I am not sure I am following. If you look at how e.g., zlib includes are set

  https://github.com/apache/mesos/blob/11de04c1bbf65d0a90576642f8ea9574e05a317a/configure.ac#L1870
  
we directly use the user-supplied prefix. If zlib was installed into `/usr` we would end up
with `/usr/include` in the include lookup path.

Similarly for many other dependencies.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review185805
-----------------------------------------------------------


On Sept. 20, 2017, 7:08 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 7:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> 
> 
> Diffs
> -----
> 
>   configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a 
> 
> 
> Diff: https://reviews.apache.org/r/62447/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message