mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 62444: Add UNREACHABLE() macro to __cxa_pure_virtual.
Date Thu, 21 Sep 2017 08:18:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62444/#review185852
-----------------------------------------------------------


Ship it!




- Benjamin Bannier


On Sept. 20, 2017, 7:07 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62444/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 7:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The function __cxa_pure_virtual must not return,
> but newer versions of clang detect that the expansion
> of the RAW_LOG() macro contains returning code paths
> for arguments other than FATAL.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 
> 
> 
> Diff: https://reviews.apache.org/r/62444/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message