mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 62418: Removed unneeded configure step in mesos-tidy Docker image.
Date Thu, 21 Sep 2017 01:14:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62418/#review185838
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62417, 62418]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 19, 2017, 8:42 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62418/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 8:42 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The mesos-tidy Docker image uses the cmake build to prepare Mesos for
> linting. The cmake build does not require running of 'bootstrap'.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/entrypoint.sh 68026f4a00abbca7fc80688b9d16718440596632 
> 
> 
> Diff: https://reviews.apache.org/r/62418/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the built image with a modified `support/mesos-tidy.sh` that does not force-download
the image.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message