mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62443: Initialized tests with Google Mock initialization.
Date Wed, 20 Sep 2017 21:01:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62443/#review185826
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Sept. 20, 2017, 11:13 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62443/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 11:13 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-7987
>     https://issues.apache.org/jira/browse/MESOS-7987
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Switched over to explicitly using Google Mock to initialize the test
> suite. This enables Google Mock option flags so that --gmock_verbose
> will be supported.
> 
> 
> Diffs
> -----
> 
>   src/tests/main.cpp cd30cac89c8d676d60a90f0ef843a68c241a0431 
> 
> 
> Diff: https://reviews.apache.org/r/62443/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> Manually verified that `--gmock_verbose=info` traces the mocked expectations.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message