mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.
Date Wed, 20 Sep 2017 00:25:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62391/#review185758
-----------------------------------------------------------



PASS: Mesos patch 62391 was successfully built and tested.

Reviews applied: `['62391']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62391

- Mesos Reviewbot Windows


On Sept. 19, 2017, 6 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62391/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2017, 6 p.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Bugs: MESOS-7988
>     https://issues.apache.org/jira/browse/MESOS-7988
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes a bug found by running `mesos-tests` under Application
> Verifier on Windows. Mesos was inadvertently attempting to get a process
> handle for the System Idle Process with PID `0`, which is not permitted
> by the OS. To remedy this, we now check if `os::process` receives `0`
> for its argument, and return an error if so. Furthermore, we remove the
> PID `0` from the `os::pids` API, as it is not useful to the programmer,
> and only serves to cause errors later. Finally, the return value for
> `OpenProcess` was being incorrectly checked, as the API returns a
> `nullptr` on failure, not `INVALID_HANDLE_VALUE`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/os.hpp f35bf312a25066a167dc66243ad9bf8333cb36a6

>   3rdparty/stout/tests/os/process_tests.cpp 963eb4eb3fb64d627e177d760bf42b777ae0e924

> 
> 
> Diff: https://reviews.apache.org/r/62391/diff/3/
> 
> 
> Testing
> -------
> 
> Built and ran `mesos-tests`, `libprocess-tests`, and `stout-tests` on Windows under Application
Verifier. All tests pass, and the error from `OpenProcess` is no longer being returned.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message