mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 62332: Linted JavaScript files.
Date Tue, 19 Sep 2017 22:19:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62332/#review185740
-----------------------------------------------------------


Fix it, then Ship it!




I will commit this without the ellipsis change, can you follow up with a separate fix for
that?


src/webui/master/static/js/app.js
Line 76 (original), 92 (patched)
<https://reviews.apache.org/r/62332/#comment262083>

    I think the use of elipsis was intentional here, have you compared the visual look before
and after this change? The no impact change here would have been to use '\u2026'?


- Benjamin Mahler


On Sept. 14, 2017, 3:29 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62332/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2017, 3:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7978
>     https://issues.apache.org/jira/browse/MESOS-7978
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a future patch, we will enable JavaScript linting. This patch
> is an update of our current JavaScript files removing the errors
> that would otherwise return ESLint.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/app.js e11f881e947c11fd9fac717f12101726c2c6e380 
>   src/webui/master/static/js/controllers.js 339dfc4786ef4b88b9a16a0eb41b9b72836d469b

>   src/webui/master/static/js/services.js afd25441813324ce54f09733fd501ebf1564ef7d 
> 
> 
> Diff: https://reviews.apache.org/r/62332/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message