mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 62162: Revert usage of `-isystem` flag.
Date Tue, 19 Sep 2017 19:49:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62162/#review185724
-----------------------------------------------------------



Mostlt LGTM, but I'd prefer if we break down the changes into more targeted patches. This
would e.g., allow us to better explain why we make them.


configure.ac
Lines 1450-1462 (patched)
<https://reviews.apache.org/r/62162/#comment262039>

    How is this related to this change?



configure.ac
Lines 1580-1587 (original)
<https://reviews.apache.org/r/62162/#comment262038>

    This seems like an unrelated change.



src/logging/logging.cpp
Lines 68 (patched)
<https://reviews.apache.org/r/62162/#comment262037>

    It seems that this fix would also warrant its own patch.


- Benjamin Bannier


On Sept. 14, 2017, 2:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62162/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> 
> 
> Diffs
> -----
> 
>   configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a 
>   src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 
> 
> 
> Diff: https://reviews.apache.org/r/62162/diff/1/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Updated boost tarball
>   https://reviews.apache.org/media/uploaded/files/2017/09/14/3e6f3c0d-5b93-408d-9fce-ff4fb1f21d43__boost-1.65.0.tar.gz
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message