mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.
Date Tue, 19 Sep 2017 03:29:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62391/#review185640
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['62391']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62391

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62391/logs/mesos-tests-stdout.log):

```
[ RUN      ] ContentType/SchedulerTest.SchedulerReconnect/0
[       OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (228 ms)
[ RUN      ] ContentType/SchedulerTest.SchedulerReconnect/1
[       OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (256 ms)
[----------] 30 tests from ContentType/SchedulerTest (25650 ms total)

[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN      ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[       OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (992 ms)
[ RUN      ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[       OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (994 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2063 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (125 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (158 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (332 ms total)

[----------] Global test environment tear-down
[==========] 627 tests from 66 test cases ran. (341688 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62391/logs/mesos-tests-stderr.log):

```
I0919 03:28:55.491580 17364 master.cpp:8418] Removing framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
(default)
I0919 03:28:55.491580 17364 master.cpp:3267] Deactivating framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
(default)
I0919 03:28:55.491580 21948 hierarchical.cpp:412] Deactivated framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
I0919 03:28:55.492578 22180 slave.cpp:3235] Shutting down framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
I0919 03:28:55.492578 17364 master.cpp:8993] Updating the state of task 1eef69ce-5917-4e39-b018-eea8b719f3f8
of framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0919 03:28:55.492578 22180 slave.cpp:5731] Shutting down executor 'default' of framework
d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000 (via HTTP)
I0919 03:28:55.504575 17364 master.cpp:9087] Removing task 1eef69ce-5917-4e39-b018-eea8b719f3f8
with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
of framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000 on agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
at slave(254)@10.3.1.5:54306 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0919 03:28:55.515578 17364 master.cpp:9116] Removing executor 'default' with resources []
of framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000 on agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
at slave(254)@10.3.1.5:54306 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0919 03:28:55.527577 22180 hierarchical.cpp:355] Removed framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
E0919 03:28:55.528578 21784 scheduler.cpp:649] End-Of-File received from master. The master
closed the event stream
I0919 03:28:55.530576 19512 scheduler.cpp:444] Re-detecting master
I0919 03:28:55.533577 19512 scheduler.cpp:470] New master detected at master@10.3.1.5:54306
I0919 03:28:55.545578 17364 slave.cpp:5407] Executor 'default' of framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
exited with status 0
I0919 03:28:55.545578 17364 slave.cpp:5511] Cleaning up executor 'default' of framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
(via HTTP)
W0919 03:28:55.546577 21784 master.cpp:7021] Ignoring unknown exited executor 'default' of
framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000 on agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
at slave(254)@10.3.1.5:54306 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0919 03:28:55.547579 22180 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\kJF7PT\slaves\d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0\frameworks\d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000\executors\default\runs\08d9a512-2960-4a5c-8a21-0ce143d2e5a8'
for gc 6.99999366228148days in the future
I0919 03:28:55.548580 17364 slave.cpp:5607] Cleaning up framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
I0919 03:28:55.560578 19512 status_update_manager.cpp:285] Closing status update streams for
framework d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
I0919 03:28:55.560578 22180 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\kJF7PT\slaves\d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0\frameworks\d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000\executors\default'
for gc 6.99999365068148days in the future
I0919 03:28:55.561579 17364 slave.cpp:861] Agent terminating
I0919 03:28:55.561579 22180 gc.cpp:91] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\kJF7PT\slaves\d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0\frameworks\d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000'
for gc 6.9999935118163days in the future
I0919 03:28:55.570580 22016 master.cpp:1321] Agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
at slave(254)@10.3.1.5:54306 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0919 03:28:55.571578 22016 master.cpp:3304] Disconnecting agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
at slave(254)@10.3.1.5:54306 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0919 03:28:55.571578 22016 master.cpp:3323] Deactivating agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
at slave(254)@10.3.1.5:54306 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0919 03:28:55.572579 22180 hierarchical.cpp:690] Agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
deactivated
I0919 03:28:55.596582 20824 master.cpp:1163] Master terminating
I0919 03:28:55.609583 22016 hierarchical.cpp:626] Removed agent d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-S0
W0919 03:28:55.617583 20824 master.hpp:2761] Failed to close HTTP pipe for d7323cfa-3c5b-401b-823a-3dc5ab9db8b1-0000
(default)
I0919 03:28:56.359222 21132 process.cpp:1068] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Sept. 18, 2017, 11:39 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62391/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2017, 11:39 p.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Bugs: MESOS-7988
>     https://issues.apache.org/jira/browse/MESOS-7988
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes a bug found by running `mesos-tests` under Application
> Verifier on Windows. Mesos was inadvertently attempting to get a process
> handle for the System Idle Process with PID `0`, which is not permitted
> by the OS. To remedy this, we now check if `os::process` receives `0`
> for its argument, and return an error if so. Furthermore, we remove the
> PID `0` from the `os::pids` API, as it is not useful to the programmer,
> and only serves to cause errors later. Finally, the return value for
> `OpenProcess` was being incorrectly checked, as the API returns a
> `nullptr` on failure, not `INVALID_HANDLE_VALUE`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/os.hpp f35bf312a25066a167dc66243ad9bf8333cb36a6

>   3rdparty/stout/tests/os/process_tests.cpp 963eb4eb3fb64d627e177d760bf42b777ae0e924

> 
> 
> Diff: https://reviews.apache.org/r/62391/diff/2/
> 
> 
> Testing
> -------
> 
> Built and ran `mesos-tests`, `libprocess-tests`, and `stout-tests` on Windows under Application
Verifier. All tests pass, and the error from `OpenProcess` is no longer being returned.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message