mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.
Date Mon, 18 Sep 2017 23:39:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62391/
-----------------------------------------------------------

(Updated Sept. 18, 2017, 4:39 p.m.)


Review request for mesos, James Peach and Joseph Wu.


Changes
-------

Fix `stout-tests`.


Bugs: MESOS-7988
    https://issues.apache.org/jira/browse/MESOS-7988


Repository: mesos


Description
-------

This patch fixes a bug found by running `mesos-tests` under Application
Verifier on Windows. Mesos was inadvertently attempting to get a process
handle for the System Idle Process with PID `0`, which is not permitted
by the OS. To remedy this, we now check if `os::process` receives `0`
for its argument, and return an error if so. Furthermore, we remove the
PID `0` from the `os::pids` API, as it is not useful to the programmer,
and only serves to cause errors later. Finally, the return value for
`OpenProcess` was being incorrectly checked, as the API returns a
`nullptr` on failure, not `INVALID_HANDLE_VALUE`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/windows/os.hpp f35bf312a25066a167dc66243ad9bf8333cb36a6 
  3rdparty/stout/tests/os/process_tests.cpp 963eb4eb3fb64d627e177d760bf42b777ae0e924 


Diff: https://reviews.apache.org/r/62391/diff/2/

Changes: https://reviews.apache.org/r/62391/diff/1-2/


Testing (updated)
-------

Built and ran `mesos-tests`, `libprocess-tests`, and `stout-tests` on Windows under Application
Verifier. All tests pass, and the error from `OpenProcess` is no longer being returned.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message