mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.
Date Mon, 18 Sep 2017 22:51:25 GMT


> On Sept. 18, 2017, 3:49 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some Mesos stdout-tests tests failed.
> > 
> > Reviews applied: `['62391']`
> > 
> > Failed command: `C:\mesos\3rdparty\stout\tests\Debug\stout-tests.exe`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62391
> > 
> > Relevant logs:
> > 
> > - [stdout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62391/logs/stdout-tests-stdout.log):
> > 
> > ```
> > [ RUN      ] SocketTests.InitSocket
> > [       OK ] SocketTests.InitSocket (1 ms)
> > [----------] 1 test from SocketTests (17 ms total)
> > 
> > [----------] 2 tests from StrerrorTest
> > [ RUN      ] StrerrorTest.ValidErrno
> > [       OK ] StrerrorTest.ValidErrno (0 ms)
> > [ RUN      ] StrerrorTest.InvalidErrno
> > [       OK ] StrerrorTest.InvalidErrno (0 ms)
> > [----------] 2 tests from StrerrorTest (58 ms total)
> > 
> > [----------] 3 tests from SystemsTests
> > [ RUN      ] SystemsTests.Uname
> > [       OK ] SystemsTests.Uname (1 ms)
> > [ RUN      ] SystemsTests.Sysname
> > [       OK ] SystemsTests.Sysname (1 ms)
> > [ RUN      ] SystemsTests.Release
> > [       OK ] SystemsTests.Release (1 ms)
> > [----------] 3 tests from SystemsTests (86 ms total)
> > 
> > [----------] Global test environment tear-down
> > [==========] 256 tests from 43 test cases ran. (12385 ms total)
> > [  PASSED  ] 255 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] ProcessTest.Pids
> > 
> >  1 FAILED TEST
> >   YOU HAVE 12 DISABLED TESTS
> > 
> > ```
> > 
> > - [stdout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62391/logs/stdout-tests-stderr.log):
> > 
> > ```
> > 'invalid.command' is not recognized as an internal or external command,
> > operable program or batch file.
> > Subcommand 'subcommand' is not available
> > Usage: command <subcommand> [OPTIONS]
> > 
> > Available subcommands:
> >     help
> >     subcommand2
> > 
> > Multiple subcommands have name 'subcommand'
> > ```

Heh, I didn't run stout-tests... my bad. Fixing.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62391/#review185627
-----------------------------------------------------------


On Sept. 18, 2017, 1:42 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62391/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2017, 1:42 p.m.)
> 
> 
> Review request for mesos, James Peach and Joseph Wu.
> 
> 
> Bugs: MESOS-7988
>     https://issues.apache.org/jira/browse/MESOS-7988
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes a bug found by running `mesos-tests` under Application
> Verifier on Windows. Mesos was inadvertently attempting to get a process
> handle for the System Idle Process with PID `0`, which is not permitted
> by the OS. To remedy this, we now check if `os::process` receives `0`
> for its argument, and return an error if so. Furthermore, we remove the
> PID `0` from the `os::pids` API, as it is not useful to the programmer,
> and only serves to cause errors later. Finally, the return value for
> `OpenProcess` was being incorrectly checked, as the API returns a
> `nullptr` on failure, not `INVALID_HANDLE_VALUE`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/windows/os.hpp f35bf312a25066a167dc66243ad9bf8333cb36a6

> 
> 
> Diff: https://reviews.apache.org/r/62391/diff/1/
> 
> 
> Testing
> -------
> 
> Built and ran `mesos-tests` on Windows under Application Verifier. All tests pass, and
the error from `OpenProcess` is no longer being returned.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message