mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.
Date Mon, 18 Sep 2017 19:46:26 GMT


> On Sept. 8, 2017, 4:40 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos tests failed to build. Please check http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62176/logs/mesos-tests-cmake-build.log
for any relevant errors
> > 
> > Reviews applied: [62105, 62106, 62176]
> > 
> > Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62176/logs

This fails because the bundle hasn't been committed to our 3rdparty repo yet, which is fine.
It just means we need to test manually, and make sure the PR gets merged.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62176/#review185035
-----------------------------------------------------------


On Sept. 8, 2017, 3:35 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62176/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2017, 3:35 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3110
>     https://issues.apache.org/jira/browse/MESOS-3110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added cmake dependency check for libsasl2 on non-Windows platforms.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
> 
> 
> Diff: https://reviews.apache.org/r/62176/diff/2/
> 
> 
> Testing
> -------
> 
> I tested this on my Ubuntu 16.04 system. When the libsasl2 library doesn't exist, it
fails the cmake configure/build.  I did not test this on any other platform, but this code
is in a "if (NOT WIN32)" block and won't affect a Windows build.  I'm uncertain if there is
much support for other kinds of builds (like Mac OS), but this should be platform independent.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message