mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
Date Mon, 18 Sep 2017 19:34:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review185613
-----------------------------------------------------------




3rdparty/CMakeLists.txt
Lines 189-213 (patched)
<https://reviews.apache.org/r/62105/#comment261911>

    Formatting issues:
    
    Since this is under a conditional, it all needs to be indented two spaces.
    
    The call to `external` we ended up standardizing as `EXTERNAL` to distinguish our functions
from CMake built-ins.
    
    The `MAKE_INCLUDE_DIR` should come after `ExternalProject_Add` for consistency with the
rest of the file.



3rdparty/CMakeLists.txt
Lines 192 (patched)
<https://reviews.apache.org/r/62105/#comment261914>

    And this is just me being super nitpicky, but I was trying to keep the `####` headers
to the length of the comments above them, and I added a short project description after the
the name so anyone new can easily know what the dependency is for. Final thing is that the
link is to an FTP server, but I would recommend just linking to the homepage "https://cyrusimap.org/sasl/".



3rdparty/CMakeLists.txt
Lines 201-202 (patched)
<https://reviews.apache.org/r/62105/#comment261912>

    Since this is an unconditionally static library, the `IMPLIB` properties do not need to
be defined (these are specifically for dealing with DLLs and their associated imports).



3rdparty/CMakeLists.txt
Lines 203-204 (patched)
<https://reviews.apache.org/r/62105/#comment261913>

    Perfect!


- Andrew Schwartzmeyer


On Sept. 8, 2017, 3:13 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2017, 3:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus-sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message