mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 62018: Updated logging::initialize to make flags optional.
Date Mon, 18 Sep 2017 19:15:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62018/#review185608
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 18, 2017, 1:05 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62018/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2017, 1:05 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7586
>     https://issues.apache.org/jira/browse/MESOS-7586
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used to initialize logging in the main functions
> that do not use `mesos::internal::logging::Flags`.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af 
>   src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 
> 
> 
> Diff: https://reviews.apache.org/r/62018/diff/4/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> Also tested manually to see if using `LOG()` without initializing GLOG gives the same
result as using it after running `mesos::internal::logging::initialize` without flags.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message