mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.
Date Mon, 18 Sep 2017 13:45:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185548
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['62381']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381

Relevant logs:

- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381/logs/mesos-tests-build-cmake-stdout.log):

```


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\checks\mesos-tcp-connect.vcxproj" (default target) (26) ->
  C:\mesos\mesos\src\checks\tcp_connect.cpp(93): warning C4244: 'initializing': conversion
from 'SOCKET' to 'int', possible loss of data [C:\mesos\src\checks\mesos-tcp-connect.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\tests\test-helper.vcxproj" (default target) (28) ->
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\active_user_test_helper.cpp)
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\active_user_test_helper.cpp)
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\http_server_test_helper.cpp)
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\http_server_test_helper.cpp)
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\src\tests\resources_utils.cpp(93): warning C4267: 'argument': conversion
from 'size_t' to 'int', possible loss of data [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW':
was declared deprecated (compiling source file C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\docker\mesos-docker-executor.vcxproj" (default target) (24) ->
(ClCompile target) -> 
  C:\mesos\mesos\src\linux/ns.hpp(22): fatal error C1189: #error:  "linux/ns.hpp is only available
on Linux systems." [C:\mesos\src\docker\mesos-docker-executor.vcxproj]

    141 Warning(s)
    1 Error(s)

Time Elapsed 00:38:37.69
```

- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_2e741.dir\Debug\cmTC_2e741.tlog\".

InitializeBuildStatus:

  Creating "cmTC_2e741.dir\Debug\cmTC_2e741.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_2e741.dir\Debug\" /Fd"cmTC_2e741.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11
/D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope
/Zc:inline /GR /Fo"cmTC_2e741.dir\Debug\" /Fd"cmTC_2e741.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue
C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe
/ERRORREPORT:QUEUE /OUT:"C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2e741.exe" /INCREMENTAL /NOLOGO
kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib
comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed
/DEBUG /PDB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2e741.pdb" /SUBSYSTEM:CONSOLE /TLBID:1
/DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2e741.lib" /MACHINE:X64
 /machine:x64 cmTC_2e741.dir\Debug\src.obj

  cmTC_2e741.vcxproj -> C:\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_2e741.exe

  cmTC_2e741.vcxproj -> C:/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_2e741.pdb (Full PDB)

FinalizeBuildStatus:

  Deleting file "cmTC_2e741.dir\Debug\cmTC_2e741.tlog\unsuccessfulbuild".

  Touching "cmTC_2e741.dir\Debug\cmTC_2e741.tlog\cmTC_2e741.lastbuildstate".

Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_2e741.vcxproj" (default targets).



Build succeeded.

    0 Warning(s)

    0 Error(s)



Time Elapsed 00:00:02.06


Source file was:
int main() { return 0; }
```

- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381/logs/mesos-tests-CMakeError.log):

```
PrepareForBuild:

  Creating directory "cmTC_99f6d.dir\Debug\".

  Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_99f6d.dir\Debug\cmTC_99f6d.tlog\".

InitializeBuildStatus:

  Creating "cmTC_99f6d.dir\Debug\cmTC_99f6d.tlog\unsuccessfulbuild" because "AlwaysCreate"
was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe
/c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE
/D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t
/Zc:forScope /Zc:inline /Fo"cmTC_99f6d.dir\Debug\" /Fd"cmTC_99f6d.dir\Debug\vc141.pdb" /Gd
/TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D
_UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise
/Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_99f6d.dir\Debug\" /Fd"cmTC_99f6d.dir\Debug\vc141.pdb"
/Gd /TC /errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c

  CheckIncludeFile.c

  

C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_99f6d.vcxproj]

Done Building Project "C:\mesos\CMakeFiles\CMakeTmp\cmTC_99f6d.vcxproj" (default targets)
-- FAILED.



Build FAILED.



"C:\mesos\CMakeFiles\CMakeTmp\cmTC_99f6d.vcxproj" (default target) (1) ->

(ClCompile target) -> 

  C:\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include
file: 'pthread.h': No such file or directory [C:\mesos\CMakeFiles\CMakeTmp\cmTC_99f6d.vcxproj]



    0 Warning(s)

    1 Error(s)



Time Elapsed 00:00:01.62



```

- Mesos Reviewbot Windows


On Sept. 18, 2017, 12:27 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2017, 12:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent huang, and Lukas
Loesche.
> 
> 
> Bugs: MESOS-4812
>     https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/1/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message