mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 62357: Updated logging initialization arguments.
Date Fri, 15 Sep 2017 15:16:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62357/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Bugs: MESOS-7586
    https://issues.apache.org/jira/browse/MESOS-7586


Repository: mesos


Description
-------

The arguments `_flags` and `installFailureSignalHandler`
are now swapped and `installFailureSignalHandler`
does not have a default value anymore.


Diffs
-----

  src/cli/execute.cpp e844fa46a43bdfb08246be929b7913a7997f18df 
  src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
  src/examples/balloon_framework.cpp a63dbab2b478b28738940114bd157a56b49d473b 
  src/examples/disk_full_framework.cpp 2572c72ded86d4befc1dc137e264dfe6ff64a357 
  src/examples/dynamic_reservation_framework.cpp bb6f58ba8fb87ae37d4ae971c192a204d5a656c5

  src/examples/load_generator_framework.cpp 653ae815df2009613b8f89308ab1b5f19757825a 
  src/examples/long_lived_framework.cpp da632040ece591717a38b44158b3eedd9f0ae7c4 
  src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc 
  src/examples/persistent_volume_framework.cpp bce2a2d1c73a3a1efab6d107529d9f6cfe9854da 
  src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7 
  src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e 
  src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644 
  src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26 
  src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
  src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
  src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87 
  src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2 
  src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968 
  src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec 
  src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75 
  src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873 
  src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af 
  src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 
  src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee 
  src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 
  src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744 
  src/slave/container_loggers/logrotate.cpp 61484b18f4615e85925b26d999afb5ac3b7e32a5 
  src/slave/containerizer/mesos/io/switchboard_main.cpp fa0b29667258b6b6fb7381d8226b6dda0062629e

  src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb 
  src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c 


Diff: https://reviews.apache.org/r/62357/diff/1/


Testing
-------

```
make check
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message