mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 62344: Made `Slave::checkDiskUsage` return a `Future`.
Date Fri, 15 Sep 2017 01:56:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62344/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-7939
    https://issues.apache.org/jira/browse/MESOS-7939


Repository: mesos


Description
-------

With a `Future` returned by `Slave::checkDiskUsage`, we are able to make
certain events (e.g., checkpointing) wait for disk GC to ensure enough
disk space.

Now `Slave::checkDiskUsage` no longer dispatch a subsequent call through
`process::delay` since it only accepts void functions. Instead, we use
`process::loop` to run `Slave::checkDiskUsage` periodically.


Diffs
-----

  src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094 
  src/slave/slave.cpp 6d1516a5d5b5db684f79385e60d892ff75fd00fd 
  src/tests/gc_tests.cpp da9a31c30e759e30492963c199da2b16e9f91550 


Diff: https://reviews.apache.org/r/62344/diff/1/


Testing
-------

Testing done in r/62336.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message