mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 62212: Send TASK_STARTING from the built-in executors.
Date Wed, 13 Sep 2017 17:29:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185310
-----------------------------------------------------------




src/docker/executor.cpp
Lines 160 (patched)
<https://reviews.apache.org/r/62212/#comment261616>

    Consider moving this comment right after `LOG(INFO) << "Starting task " <<
taskId.get();`.



src/launcher/default_executor.cpp
Line 326 (original), 332 (patched)
<https://reviews.apache.org/r/62212/#comment261617>

    Should we update the comment above?



src/launcher/default_executor.cpp
Lines 412 (patched)
<https://reviews.apache.org/r/62212/#comment261618>

    Adding default constructor for `DefaultExecutor::Container` will help us to get rid of
repeating `None()` and `false`.



src/launcher/executor.cpp
Line 1019 (original), 1023 (patched)
<https://reviews.apache.org/r/62212/#comment261612>

    As you have moved
    ```c++
    TaskStatus starting = createTaskStatus(taskId.get(), TASK_STARTING);
    forward(starting);
    ```
    after `taskData = TaskData(task);`, this change is not necessarry anymore and can be reverted.


- Andrei Budnik


On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0

>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message