mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.
Date Tue, 12 Sep 2017 13:14:23 GMT


> On April 17, 2017, 11:49 a.m., Jie Yu wrote:
> > src/tests/resources_tests.cpp
> > Lines 2255 (patched)
> > <https://reviews.apache.org/r/58048/diff/3/?file=1685272#file1685272line2255>
> >
> >     instead of relying on 'count', let's use `size()` instead.
> 
> Qian Zhang wrote:
>     I think here the intention is to count how many `disks` are in `(r1 + r2)`, so `count()`
should be the right method to call.
> 
> Benjamin Bannier wrote:
>     Yes, exactly. Note that we could use `size` and explicit value checks here, but this
would introduce dependencies to the exact disk values which in my opinion makes the code harder
to understand.

I removed the code here, but `count` has incorrect semantics (number of users of shared resource
instead of number of appearances of a specific `Resource`). I use `size` in newly added code
now (an alternative possibility would have been to first filter for a `Resource` and then
check the `size` of the result).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/#review172076
-----------------------------------------------------------


On Sept. 12, 2017, 3:14 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58048/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 3:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-7312
>     https://issues.apache.org/jira/browse/MESOS-7312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ids will allow to create distinguishable resources, e.g., of RAW or
> BLOCK type. We also add a metadata field which can be used to expose
> additional disk information.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
>   include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
>   src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
>   src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 
> 
> 
> Diff: https://reviews.apache.org/r/58048/diff/5/
> 
> 
> Testing
> -------
> 
> make check (OS X, Fedora25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message