mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Review Request 62240: Removed metrics removal from Master::failoverFramework().
Date Tue, 12 Sep 2017 12:59:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62240/
-----------------------------------------------------------

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-7867
    https://issues.apache.org/jira/browse/MESOS-7867


Repository: mesos


Description
-------

When a framework upgrades from a PID based driver to an HTTP based
driver, the master removes its per-principal metrics. When the same
framework downgrades back to a PID based driver, the master doesn't
reinstate those metrics. This causes a crash when the master receives a
message from the failed over framework and tries to increment its
metrics.

This patch fixes the issue by removing metrics removal from framework
failover handling code. Note that it doesn't handle the case when the
framework's principal change. This situation is being dealt with
separately in MESOS-2842.


Diffs
-----

  src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 


Diff: https://reviews.apache.org/r/62240/diff/1/


Testing
-------

Ran `make check`. A regression test that reproduces the issue is added in the subsequent patch.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message