mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 62018: Updated logging::initialize to make flags optional.
Date Tue, 12 Sep 2017 11:33:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62018/
-----------------------------------------------------------

(Updated Sept. 12, 2017, 11:33 a.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Changes
-------

Resolved issue.


Bugs: MESOS-7586
    https://issues.apache.org/jira/browse/MESOS-7586


Repository: mesos


Description
-------

Thiw will be used to initialize logging in the main functions
that do not use mesos::internal::logging::Flags.


Diffs (updated)
-----

  src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af 
  src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 


Diff: https://reviews.apache.org/r/62018/diff/3/

Changes: https://reviews.apache.org/r/62018/diff/2-3/


Testing (updated)
-------

```
$ make check
```

Also tested manually to see if using `LOG()` without initializing GLOG gives the same result
as using it `LOG()` after running `mesos::internal::logging::initialize` without flags.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message