mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 62018: Updated logging::initialize to make flags optional.
Date Mon, 11 Sep 2017 13:53:17 GMT


> On Sept. 8, 2017, 12:30 p.m., Andrei Budnik wrote:
> > src/logging/logging.cpp
> > Line 156 (original), 165 (patched)
> > <https://reviews.apache.org/r/62018/diff/2/?file=1816180#file1816180line167>
> >
> >     What will be the value of `FLAGS_logtostderr` if `_flags` is `None`? Does it
mean that messages via `LOG` won't be written to `stdout`/`stderr`?

By default, `FLAGS_logtostderr` value is 0. Thus we will not log to stderr instead of log
files.


- Armand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62018/#review184968
-----------------------------------------------------------


On Sept. 6, 2017, 9:48 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62018/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 9:48 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7586
>     https://issues.apache.org/jira/browse/MESOS-7586
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Thiw will be used to initialize logging in the main functions
> that do not use mesos::internal::logging::Flags.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af 
>   src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 
> 
> 
> Diff: https://reviews.apache.org/r/62018/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message