mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Review Request 62203: Use a `process::Executor` to ensure safety of asynchronous callbacks.
Date Sat, 09 Sep 2017 05:40:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62203/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Repository: mesos


Description
-------

When passing callbacks to `scheduler::Mesos` and `executor::Mesos`
from the tests `TestMesos` it's possible that we'll invoke those
callbacks erroneously after we've destructed `TestMesos` because the
callbacks are executed asynchronously. By using a `process::Executor`
we can guarantee that after `TestMesos` is destroyed (and thereby the
`process::Executor` instance is destroyed) we won't execute the
callbacks.


Diffs
-----

  src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 


Diff: https://reviews.apache.org/r/62203/diff/1/


Testing
-------

make check


Thanks,

Benjamin Hindman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message