mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 62037: Added logging::initialize to main functions that use glog.
Date Fri, 08 Sep 2017 12:14:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62037/#review184967
-----------------------------------------------------------




src/checks/tcp_connect.cpp
Line 119 (original), 119 (patched)
<https://reviews.apache.org/r/62037/#comment261190>

    Should we move it one line before `testTCPConnect`?
    It looks like initialization code which should go right after parsing/validating of flags,
isn't it?



src/checks/tcp_connect.cpp
Line 138 (original), 140 (patched)
<https://reviews.apache.org/r/62037/#comment261189>

    Consider moving it just after `Try<flags::Warnings> load = flags.load(None(), argc,
argv);` line.



src/cli/execute.cpp
Lines 919 (patched)
<https://reviews.apache.org/r/62037/#comment261191>

    I would prefer passing `installFailureSignalHandler = true` here and everywhere for `logging::initialize`
- it will help us a lot debugging them.



src/cli/execute.cpp
Line 956 (original), 957 (patched)
<https://reviews.apache.org/r/62037/#comment261188>

    Do we need `return EXIT_FAILURE` here?


- Andrei Budnik


On Sept. 6, 2017, 9:57 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62037/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 9:57 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7586
>     https://issues.apache.org/jira/browse/MESOS-7586
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change reduces the number of messages "WARNING: Logging
> before InitGoogleLogging() is written to STDERR".
> 
> 
> Diffs
> -----
> 
>   src/checks/tcp_connect.cpp 3cb9077b9f39f69fdc152280e5b180b88e772648 
>   src/cli/execute.cpp e844fa46a43bdfb08246be929b7913a7997f18df 
>   src/cli/resolve.cpp b3cba87f61dbff0e99291775a4d0908bb35ce811 
>   src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 
>   src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 
>   src/examples/dynamic_reservation_framework.cpp bb6f58ba8fb87ae37d4ae971c192a204d5a656c5

>   src/examples/long_lived_framework.cpp 3de4a0280c41db5dcf656ac89cb4168060190108 
>   src/examples/no_executor_framework.cpp 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc 
>   src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7 
>   src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e 
>   src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87 
>   src/slave/container_loggers/logrotate.cpp 61484b18f4615e85925b26d999afb5ac3b7e32a5

>   src/slave/containerizer/mesos/io/switchboard_main.cpp fa0b29667258b6b6fb7381d8226b6dda0062629e

>   src/usage/main.cpp 5ad4a3ba7959e4a9b3fa05f5a2f49b02f94a0cf0 
> 
> 
> Diff: https://reviews.apache.org/r/62037/diff/2/
> 
> 
> Testing
> -------
> 
> ```
> make check
> ```
> 
> Had an issue with ExamplesTest.DiskFullFramework that is not related.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message