mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 60593: Added `network/ports` isolator recovery tests.
Date Thu, 07 Sep 2017 21:57:18 GMT


> On Aug. 23, 2017, 2:53 p.m., Qian Zhang wrote:
> > src/tests/containerizer/ports_isolator_tests.cpp
> > Lines 853 (patched)
> > <https://reviews.apache.org/r/60593/diff/11/?file=1801024#file1801024line853>
> >
> >     It seems there is no enough time left for this code because we stop the `driver`
right after the check is triggered.
> 
> James Peach wrote:
>     I looked at this for a while and consulted with @xujyan and we couldn't come up with
a way to prove that the process is still running. The `settle()` gives us confidence that
no limitation was raised, but I don't know how to guarantee that. Can you sujjest an approach?

Fixed by verifying that we can explicitly kill the task (same fix for the corresponding nested
container test).


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60593/#review183580
-----------------------------------------------------------


On Aug. 31, 2017, 12:08 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60593/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2017, 12:08 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for the `network/ports` isolator recovery by starting
> a task that is listening on a rogue port. We only configure the
> isolator when we restart the agent to simulate the case where a
> task only starts to misbehave after an agent recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60593/diff/14/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message