mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 62047: Allowed look up latest executor directory by virtual path.
Date Thu, 07 Sep 2017 21:18:38 GMT


> On Sept. 6, 2017, 9:28 p.m., Benjamin Mahler wrote:
> > src/slave/slave.cpp
> > Lines 7466-7470 (original), 7484-7491 (patched)
> > <https://reviews.apache.org/r/62047/diff/1/?file=1813736#file1813736line7484>
> >
> >     What was going on here originally with the two different calls?

rebase error


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62047/#review184737
-----------------------------------------------------------


On Sept. 1, 2017, 10:54 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62047/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jason Lai.
> 
> 
> Bugs: MESOS-7899
>     https://issues.apache.org/jira/browse/MESOS-7899
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added support to attach a virtual path
> `/frameworks/{framework-id}/executors/{executor-id}/latest` to `Files` class
> in agent, which can be used to navigate an executor's latest sandbox without
> needing to know `work_dir` and `slave_id`.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.hpp 51b481fc0870f1e95448f85ee2fd485fceea1919 
>   src/slave/paths.cpp 1a6943f03493079ab291616d3e36e0fd8809cf33 
>   src/slave/slave.cpp df920ec07cd59c7ba6baccfc1c20ed3809f187d6 
> 
> 
> Diff: https://reviews.apache.org/r/62047/diff/1/
> 
> 
> Testing
> -------
> 
> Ran a master/agent pair, launch a task with `mesos-execute` and use `files/browse` endpoint
to browse the virtual path.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message