-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60890/#review184866
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/agent/agent.proto
Lines 188 (patched)
<https://reviews.apache.org/r/60890/#comment261062>
Remove the `within an executor's tree of containers` because nested container can be nested
under top-level container as well?
Also, i'd try to use the same term to refer to 'standalone container'. Let's avoid using
the term `top level container` to refer to standalone container because top level container
also applies to executor's container.
- Jie Yu
On Sept. 7, 2017, 12:37 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60890/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 12:37 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Launching a standalone container is very similar to launching a
> nested container, except that the caller must specify some Resources.
> As such, this patch deprecates some nested container APIs
> and replaces them with more generically named APIs.
>
> This applies to the Launch, Wait, Kill, and Remove
> (nested) container APIs.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 7c8c8a7d8298e91e4e002327b3b27d4c74b5cbae
> include/mesos/v1/agent/agent.proto 3e199124b23fa027232790d99370fe2f33660096
>
>
> Diff: https://reviews.apache.org/r/60890/diff/3/
>
>
> Testing
> -------
>
> make
>
> See later patches in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
|