mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.
Date Thu, 07 Sep 2017 18:09:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62042/
-----------------------------------------------------------

(Updated Sept. 7, 2017, 6:09 p.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, and Joerg Schad.


Changes
-------

Rebased + fixed a few occurences that I had missed.


Bugs: MESOS-7877
    https://issues.apache.org/jira/browse/MESOS-7877


Repository: mesos


Description
-------

Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.


Diffs (updated)
-----

  src/tests/api_tests.cpp 0902a66772d178505e83b81878b7878a45c7bb25 
  src/tests/check_tests.cpp cc7be317030d147c5617e784a50e42b0365b9df6 
  src/tests/container_logger_tests.cpp 97e79792d3ea8023890ad2a705db47f2aeb419cf 
  src/tests/containerizer/cgroups_isolator_tests.cpp 68b8181b9c6eb9ce2e8c3c8980451364d410516b

  src/tests/containerizer/cpu_isolator_tests.cpp f7cab58b75994dc38eede6a84556ae73d412e1a1

  src/tests/containerizer/environment_secret_isolator_tests.cpp 38fef2d5f677f768a0533d1ac085b1197b3b764d

  src/tests/containerizer/io_switchboard_tests.cpp de42be9ae2019c7cdb24a0976a8565631a12fca3

  src/tests/containerizer/linux_capabilities_isolator_tests.cpp a1ff9b5e67fcccb8aa9afd90ca704796c1b0a252

  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 1ad9464e99b7dd4dfd2c9bd1a4c6c9c5cce615bd

  src/tests/containerizer/memory_isolator_tests.cpp a7028da62b27b109cb455048acbea0976da9a140

  src/tests/containerizer/memory_pressure_tests.cpp eec2e05d399d097fcb997bb44e353b9c3e0563f7

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp f7a715812001f61748749c5cecbed9376fc9ef17

  src/tests/containerizer/port_mapping_tests.cpp 544eaef1215f309f67ae177249c209afc71c5d5e

  src/tests/containerizer/runtime_isolator_tests.cpp 8bf6a11de85d4dacf081c009ace9e7b78e904849

  src/tests/containerizer/xfs_quota_tests.cpp 11dc7f596671d373cd0c9b443a1d217053285a63 
  src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 
  src/tests/disk_quota_tests.cpp 3bf0508238a228d86737d6cc899fa68e2046f2e2 
  src/tests/exception_tests.cpp 0e72cdfce2f12a6961efefb23fe14eadbadce01f 
  src/tests/fault_tolerance_tests.cpp 5ac38a897fefb6f40d69ca6e27a6f23176e42d36 
  src/tests/gc_tests.cpp da9a31c30e759e30492963c199da2b16e9f91550 
  src/tests/health_check_tests.cpp 2c43241a5cc245a1797ea16c68c94638cec6803d 
  src/tests/hook_tests.cpp c5acbd0fde7cb0923779a925fe2f6a8214be4163 
  src/tests/http_fault_tolerance_tests.cpp f05aee8200e05b10595fd821413f44bc36839de2 
  src/tests/master_authorization_tests.cpp a776a5811b66cb93cfc3484c183e815248dea944 
  src/tests/master_maintenance_tests.cpp 7595e8b1d8360920f61af4685e210c9a9f4569af 
  src/tests/master_slave_reconciliation_tests.cpp 0b26953c73c3a41e7f5e4e62a41a0756fb2097e2

  src/tests/master_tests.cpp 59fbad468ae671a8fd39457632262015989f26c2 
  src/tests/master_validation_tests.cpp 710b25c1afdff4de7b2eb9b8a38f6856c373fb3c 
  src/tests/oversubscription_tests.cpp a4c4a6083a2cb55e2d69eba1719555a7a13ee8fb 
  src/tests/persistent_volume_tests.cpp 3e1d1fe468298186347b07b5882973c5a16231a3 
  src/tests/reconciliation_tests.cpp 728961874239c7e5ce8accbaeb2a1c86a73a4f0f 
  src/tests/registrar_zookeeper_tests.cpp 96bae295bdbe839b979b879cc4b11fddcce6ad75 
  src/tests/reservation_endpoints_tests.cpp 3278732cb130c73be0f20c0204eddaee05123ff9 
  src/tests/resource_offers_tests.cpp dc9c230548ba49e92228c6625597b2294e65ca30 
  src/tests/scheduler_driver_tests.cpp d2aff699dc33d2a246b391d6322d271e7f0252b6 
  src/tests/scheduler_tests.cpp 21f8825c214bb0c331f66bfb9b12a354d6673a43 
  src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a 
  src/tests/slave_recovery_tests.cpp 0e46748be266809c413fb10fc447516c51504fce 
  src/tests/slave_tests.cpp 1bdadce4c50cbff958f2be2a4261e130b414acfd 
  src/tests/status_update_manager_tests.cpp 6922ee353123bc024c66a6bc4fadc96450287447 
  src/tests/teardown_tests.cpp 8834333bbcdb6a04a95a6ed9632ad4ead0791f76 


Diff: https://reviews.apache.org/r/62042/diff/2/

Changes: https://reviews.apache.org/r/62042/diff/1-2/


Testing
-------

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message