mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.
Date Thu, 07 Sep 2017 15:01:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62148/#review184820
-----------------------------------------------------------



FAIL: Some Mesos tests failed. Please check http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62148/logs/mesos-tests-stdout.log
and http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62148/logs/mesos-tests-stderr.log
for any relevant errors

Reviews applied: [62148]

Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62148/logs

- Mesos Reviewbot Windows


On Sept. 7, 2017, 5:54 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62148/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 5:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of relying on `Clock::pause()/settle()` to ensure that no
> callbacks on the scheduler were in flight, the test
> helper can wait on the future returned by `stop()` now. This is
> possible as we acquire the mutex explicitly in `stop()` to ensure
> that there can't be any queued callbacks that get executed after
> `TestMesos` is destroyed.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler.hpp d56e08861d5190ef66992d383dc5710d8f6ce661 
>   src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744 
>   src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 
> 
> 
> Diff: https://reviews.apache.org/r/62148/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Ensured tests still work when run in a loop)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message