mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.
Date Thu, 07 Sep 2017 01:18:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184766
-----------------------------------------------------------




src/CMakeLists.txt
Line 620 (original), 616 (patched)
<https://reviews.apache.org/r/62106/#comment260970>

    Hey John,
    
    Since you're right here already. Can you to a `find_library()` guard around `sasl2` to
for Linux? It's the last third party dependency (that I know of) that isn't actually a target.
So this line of code ends up just being `-lsasl2` and can fail at link time instead of configuration
time.
    
    You can totally do it a separate commit, but it'll close out https://issues.apache.org/jira/browse/MESOS-3110
finally :D
    
    Thanks!


- Andrew Schwartzmeyer


On Sept. 6, 2017, 6:11 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 6:11 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled CRAM MD5 Authentication on Windows and associated tests.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb 
>   docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f 
>   src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 
>   src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5

>   src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c

>   src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691 
>   support/windows-build.bat 100013ed68ecc2f431c20a3f081f8aa6eca961ef 
> 
> 
> Diff: https://reviews.apache.org/r/62106/diff/3/
> 
> 
> Testing
> -------
> 
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows,
with no errors.  Ran tests on both platforms as well.  Note: The mesos-3rdparty pull request
which contains the cyrus-sasl package needs to be merged to master first before these patches
will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured
with mesos)
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message