mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
Date Thu, 07 Sep 2017 01:14:55 GMT


> On Sept. 6, 2017, 8:48 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/cyrus_sasl-2.1.27rc3.patch
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/62105/diff/2/?file=1816648#file1816648line1>
> >
> >     Since it's a patch, I won't review it too much. However, we should ensure we
submit this change upstream to libsasl2, and at that point clean it up a bit.

Unfortunately, they will not take this patch.  I had to make some changes to make libsasl2
build statically, and enabled it to build only one of the modules.  In order to build many
of the authentication modules, many different development headers need to be installed on
the system building those modules, which we don't have right now.  I could spend more time
and make the build  configurable so only modules which have headers would be built, but I
think that's not within the scope of what I'm working on right now. But if Li thinks this
is important, I'm fine with doing it.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184728
-----------------------------------------------------------


On Sept. 7, 2017, 1:11 a.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 1:11 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message