mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James DeFelice <james.defel...@gmail.com>
Subject Re: Review Request 58021: Added storage-related offer operations.
Date Wed, 06 Sep 2017 20:55:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58021/#review184731
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 1835 (patched)
<https://reviews.apache.org/r/58021/#comment260925>

    I'd love to see documentation for these new operations to distinguish them from the CREATE
and DESTROY operations


- James DeFelice


On Aug. 31, 2017, 11:33 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58021/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2017, 11:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
>     https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added storage-related offer operations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto eede0827fc0da5f2fa3cfb432fde29b95a8c644c 
>   include/mesos/v1/mesos.proto 8c6246ee824f28d93dc5b57d25939d1ba76c986b 
>   src/common/protobuf_utils.cpp 3ae68e93a985a4cfe23be9c9bd8f92e418102a39 
>   src/common/resources.cpp 8d4388935ada6be60448e6f6a88db0e5fc4ad4a1 
>   src/common/resources_utils.cpp 821bd0967d55f7fbcb57a4efae5fc390af53ca79 
>   src/master/master.cpp 4fa05fa309e4302d18cb9557a4730bd5f8dd29e6 
>   src/v1/resources.cpp 508f3f85c8388a41f57f964b0f6df3b4708d3442 
> 
> 
> Diff: https://reviews.apache.org/r/58021/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message