mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.
Date Wed, 06 Sep 2017 20:42:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62106/#review184725
-----------------------------------------------------------




cmake/CompilationConfigure.cmake
Lines 114-121 (original)
<https://reviews.apache.org/r/62106/#comment260915>

    Yay!



docs/windows.md
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/62106/#comment260916>

    We probably need to update `support/windows-build.bat` too.



src/CMakeLists.txt
Lines 619-622 (original), 615-623 (patched)
<https://reviews.apache.org/r/62106/#comment260917>

    This might read better as an if/else.



src/authentication/cram_md5/authenticatee.cpp
Lines 21 (patched)
<https://reviews.apache.org/r/62106/#comment260919>

    I admittedly personally prefer `#if defined(WIN32)`; however, AFAIK, we're explicitly
using `#ifdef __WINDOWS__` and should stick to convention (until if/when we replace it).
    
    NOTE: I definitely saw a couple uses of `#if defined(__WINDOWS__)` so perhaps this is
already not a strict convention.


- Andrew Schwartzmeyer


On Sept. 6, 2017, 1:35 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62106/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 1:35 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled CRAM MD5 Authentication on Windows and associated tests.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb 
>   docs/windows.md b47ba5a0db3d41d6f4bb002283b40622a2bb3e0f 
>   src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 
>   src/authentication/cram_md5/authenticatee.cpp 7b3f767e29163de489018081089e67a6f22971c5

>   src/authentication/cram_md5/authenticator.cpp 2a12bb3f4aec79056ec6c82a8c896ee3af15bb4c

>   src/authentication/cram_md5/auxprop.hpp dedcbe514283dd86a924d92ccdd17173ebe878cb 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/authentication_tests.cpp b04be76d23788fbde337eaf85716ec7436ade691 
> 
> 
> Diff: https://reviews.apache.org/r/62106/diff/2/
> 
> 
> Testing
> -------
> 
> Ran the automake build and the cmake build on Linux, as well as the cmake build on Windows,
with no errors.  Ran tests on both platforms as well.  Note: The mesos-3rdparty pull request
which contains the cyrus-sasl package needs to be merged to master first before these patches
will work. (Or, have the cyrus-sasl tarball available in a local 3rdparty directory, configured
with mesos)
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message