mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
Date Wed, 06 Sep 2017 19:07:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62105/#review184712
-----------------------------------------------------------




3rdparty/CMakeLists.txt
Lines 208 (patched)
<https://reviews.apache.org/r/62105/#comment260908>

    This needs to change, but I'm not sure how to use cmake appropriately here.  We should
be able to inherit the configure command from the main mesos build, I think.  How would I
do this? Maybe an "add_subdirectory"?


- John Kordich


On Sept. 6, 2017, 12:05 a.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62105/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 12:05 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-3384
>     https://issues.apache.org/jira/browse/MESOS-3384
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 
>   3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 
>   3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp faf94909f995f7486b5f9cb7532af58a90a9eed3

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp ee5ea3dee3be197e923be544aab96806f0adf1cf

>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 76cc007963b4cbe162556d03d3e41a0a5e660167

>   src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 2bc9b0890d384e9ce8d5d4679c974c5e88231eed

> 
> 
> Diff: https://reviews.apache.org/r/62105/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message