mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Review Request 62071: Added non-src files to CMake project to facilitate indexing.
Date Mon, 04 Sep 2017 18:01:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62071/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Repository: mesos


Description
-------

Some IDEs and indexing tools build the project structure from CMake
target definitions. In this case files that are not essential for
building the target and are omitted from the target declaration,
do not appear in the project either and hence are not searchable
inside the IDE or indexing tool.


Diffs
-----

  CMakeLists.txt e08fcef746460b601c1bddf9e0f00cad31500ec9 
  src/CMakeLists.txt 0562b2bf87fb6e2b65a2a512e694e89ee431738b 


Diff: https://reviews.apache.org/r/62071/diff/1/


Testing
-------

Run CMake and ensured configure + generate passes;
Run Qt Creator with the built-in CMake plugin and verified the change adds files to the project
structure and makes them searchable in Qt Creator.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message