mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 62037: Added logging::initialize to main functions that use glog.
Date Mon, 04 Sep 2017 13:39:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62037/#review184488
-----------------------------------------------------------



What about
`long_lived_framework.cpp`,
`no_executor_framework.cpp`,
`test_framework.cpp`,
`test_http_framework.cpp`,
`launcher/fetcher.cpp`,
`switchboard_main.cpp`,
`tests/main.cpp`?


src/checks/tcp_connect.cpp
Lines 39-40 (patched)
<https://reviews.apache.org/r/62037/#comment260643>

    `tcp-connect` binary was not meant to use glog (for performance and dependency reasons;
it does not use libprocess either). However, it seems to be introduced during a windows-related
update. Let's not introduce a new dependency; instead, let's remove `EXIT()` macro usage.



src/cli/execute.cpp
Lines 923-926 (original), 927-930 (patched)
<https://reviews.apache.org/r/62037/#comment260646>

    Now you can use `EXIT(EXIT_FAILURE) << ...` instead. Here and below.



src/cli/execute.cpp
Lines 1202-1204 (original), 1206-1208 (patched)
<https://reviews.apache.org/r/62037/#comment260647>

    Explicitly call `process::initialize()` here?



src/cli/resolve.cpp
Lines 73-81 (original), 75-83 (patched)
<https://reviews.apache.org/r/62037/#comment260648>

    Don't you need to swap those according to MESOS-7586?



src/cli/resolve.cpp
Lines 83-86 (original), 85-90 (patched)
<https://reviews.apache.org/r/62037/#comment260650>

    This binary does not seem to use glog except logging flag failures. Please either `glog`ify
the complete binary or remove `LOG(WARNING)` instance. I suggest doing the latter, because
there is not much value in using `glog` here (not a long running process).



src/cli/resolve.cpp
Lines 90-91 (original), 94-95 (patched)
<https://reviews.apache.org/r/62037/#comment260649>

    `EXIT(EXIT_FAILURE) << ` instead, please. Here and below.



src/examples/balloon_framework.cpp
Lines 487-491 (original), 487-491 (patched)
<https://reviews.apache.org/r/62037/#comment260651>

    What about `--help`?



src/examples/balloon_framework.cpp
Lines 560-563 (original), 562-565 (patched)
<https://reviews.apache.org/r/62037/#comment260653>

    Please move this up and update the comment.



src/examples/disk_full_framework.cpp
Lines 441-445 (original), 441-445 (patched)
<https://reviews.apache.org/r/62037/#comment260652>

    `--help`?



src/examples/disk_full_framework.cpp
Line 447 (original), 447-449 (patched)
<https://reviews.apache.org/r/62037/#comment260654>

    Print warnings?



src/examples/dynamic_reservation_framework.cpp
Lines 366-375 (original), 366-375 (patched)
<https://reviews.apache.org/r/62037/#comment260656>

    Let's use the common pattern (described in MESOS-7586) instead of this blob.



src/examples/dynamic_reservation_framework.cpp
Lines 377-378 (patched)
<https://reviews.apache.org/r/62037/#comment260655>

    We should do it before using `EXIT(EXIT_FAILURE)`.



src/slave/container_loggers/logrotate.cpp
Lines 229-231 (original), 231-233 (patched)
<https://reviews.apache.org/r/62037/#comment260657>

    We can't use `EXIT(EXIT_FAILURE)` yet. Please rework this piece to follow the procedure
suggested in MESOS-7586



src/usage/main.cpp
Lines 71-79 (original), 73-81 (patched)
<https://reviews.apache.org/r/62037/#comment260658>

    Swap.



src/usage/main.cpp
Lines 81-84 (original), 83-88 (patched)
<https://reviews.apache.org/r/62037/#comment260660>

    As mentioned for another `cli/` binary, it looks it was not intended to use glog at all.
Please see my comment above for more info.


- Alexander Rukletsov


On Sept. 1, 2017, 3:47 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62037/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 3:47 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7586
>     https://issues.apache.org/jira/browse/MESOS-7586
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change reduces the number of messages "WARNING: Logging
> before InitGoogleLogging() is written to STDERR".
> 
> 
> Diffs
> -----
> 
>   src/checks/tcp_connect.cpp 3cb9077b9f39f69fdc152280e5b180b88e772648 
>   src/cli/execute.cpp e844fa46a43bdfb08246be929b7913a7997f18df 
>   src/cli/resolve.cpp b3cba87f61dbff0e99291775a4d0908bb35ce811 
>   src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6 
>   src/examples/disk_full_framework.cpp f9d5af5e45d5736581ce2c5395c741c995332136 
>   src/examples/dynamic_reservation_framework.cpp bb6f58ba8fb87ae37d4ae971c192a204d5a656c5

>   src/slave/container_loggers/logrotate.cpp 61484b18f4615e85925b26d999afb5ac3b7e32a5

>   src/usage/main.cpp 5ad4a3ba7959e4a9b3fa05f5a2f49b02f94a0cf0 
> 
> 
> Diff: https://reviews.apache.org/r/62037/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> make check
> ```
> 
> Had an issue with ExamplesTest.DiskFullFramework that is not related.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message