mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <ben...@yandex-team.ru>
Subject Re: Review Request 61495: Add documentation for possible task reasons.
Date Mon, 04 Sep 2017 10:47:45 GMT


> On Aug. 31, 2017, 2:08 p.m., Alexander Rukletsov wrote:
> > docs/task-state-reasons.md
> > Lines 162-163 (patched)
> > <https://reviews.apache.org/r/61495/diff/6/?file=1803743#file1803743line162>
> >
> >     You use 3rd and 4th caption level inconsistently: sometimes you repeat caption
for the state, and sometimes you do not.
> >     
> >     I would suggest to get rid of the 4th level altogether and have 3rd level captions
in form "For `TASK_KILLED` updates with `SOURCE_SLAVE`"

I removed the additional 3rd-level captions instead, because they look very noisy in the generated
HTML


> On Aug. 31, 2017, 2:08 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto
> > Lines 2149-2150 (original)
> > <https://reviews.apache.org/r/61495/diff/6/?file=1803744#file1803744line2149>
> >
> >     I thought you remove the comment in the next patch?

I thought so too. I'll try to revert this again, if reviewboard will let me.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61495/#review184244
-----------------------------------------------------------


On Sept. 4, 2017, 10:47 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61495/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2017, 10:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, James Peach, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5078
>     https://issues.apache.org/jira/browse/MESOS-5078
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add documentation for possible task reasons.
> 
> 
> Diffs
> -----
> 
>   docs/home.md ad91f2fe23b39d59dc021428899069531fce9970 
>   docs/task-state-reasons.md PRE-CREATION 
>   include/mesos/mesos.proto eede0827fc0da5f2fa3cfb432fde29b95a8c644c 
>   include/mesos/v1/mesos.proto 8c6246ee824f28d93dc5b57d25939d1ba76c986b 
> 
> 
> Diff: https://reviews.apache.org/r/61495/diff/7/
> 
> 
> Testing
> -------
> 
> Built website with site/build.sh and verified it renders ok.
> 
> HTML preview: http://htmlpreview.github.io/?https://github.com/lava/mesos/blob/bennoe/task-reasons/site/publish/documentation/latest/task-state-reasons/index.html
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message