mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 62017: Allows port mapper plugin to have optional args.
Date Sun, 03 Sep 2017 14:35:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62017/#review184468
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
Lines 141-143 (original), 141-144 (patched)
<https://reviews.apache.org/r/62017/#comment260618>

    What about changing the comment like the below?
    ```
      // While the 'args' field is optional in the CNI spec it is critical
      // to the port-mapper plugin to learn of any port-mappings that the
      // framework might have requested for this container when this plugin
      // is called in the Mesos context. However, to make the port-mapper
      // plugin can be used in a more generic environment rather than Mesos
      // specific, we will create a fake 'args` field if it is not filled by
      // the caller.
    ```



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
Line 146 (original), 147 (patched)
<https://reviews.apache.org/r/62017/#comment260616>

    I do not think we need this comment because there is an exactly same one in the above.


- Qian Zhang


On Sept. 1, 2017, 12:16 a.m., Deepak Goel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62017/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 12:16 a.m.)
> 
> 
> Review request for mesos and Avinash sridharan.
> 
> 
> Bugs: mesos-7923
>     https://issues.apache.org/jira/browse/mesos-7923
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos port mapper cni plugin is a wrapper around bridge plugin
> to add port mapping functionality to bridge plugin. However, in
> certain cases the network creator doesn't need port mapping
> functionality and just want to access bridge plugin. In this case,
> the creator may not supply `args` in cni config which will makes
> mesos port mapper plugin to fail. This patch makes `args` in cni
> config optional for mesos port mapper plugin
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
43cf3e44a55c56dc8195c9cd05f6edd8bf13d448 
> 
> 
> Diff: https://reviews.apache.org/r/62017/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deepak Goel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message