mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 60087: CLI: Added the ability for a plugin command to have an alias.
Date Sun, 03 Sep 2017 10:21:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60087/#review184466
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60087]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 3, 2017, 1:33 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60087/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2017, 1:33 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used by future plugins.
> 
> 
> Diffs
> -----
> 
>   src/python/cli_new/lib/cli/plugins/base.py edbe1ec3ce733faea0fd416c51a0884645da3dff

> 
> 
> Diff: https://reviews.apache.org/r/60087/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message