mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Review Request 62053: Removed garbage collector.
Date Sat, 02 Sep 2017 15:07:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62053/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Bugs: MESOS-7921
    https://issues.apache.org/jira/browse/MESOS-7921


Repository: mesos


Description
-------

The garbage collector had at least two bugs:

(1) If someone dispatched `manage()` twice in a row the process we're
    waiting for will get overwritten which can wreak havoc depending
    on when the calls to `link()` happen.

(2) The garbage collector was deleting after an exited event rather
    than actually doing a `wait()`.

The simpler implementation that this patch introduces is to just
delete the process in `ProcessManager::cleanup()`.


Diffs
-----

  3rdparty/libprocess/include/Makefile.am c5dc0bb0d2d77987531ead50277940700c62b84f 
  3rdparty/libprocess/include/process/gc.hpp 603bb8bb084a8d2774ab1077da671f659a22a376 
  3rdparty/libprocess/include/process/process.hpp 8cca782ae89727bc5570afc4ed96c556f14c8c68

  3rdparty/libprocess/src/process.cpp afa53537a5c7d4d8b0f4e3b8e04d7d0f2c4c6631 
  3rdparty/libprocess/src/tests/process_tests.cpp 8d36600701a795a7fa8d73a844657ff98eee6aa7



Diff: https://reviews.apache.org/r/62053/diff/1/


Testing
-------

make check


Thanks,

Benjamin Hindman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message