mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61308: Updated the ZooKeeper patch.
Date Sat, 02 Sep 2017 14:26:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61308/#review184419
-----------------------------------------------------------



As we discussed offline, I'm going to update/replace the file in this review with this: https://github.com/andschwa/mesos/commit/47cc9f9d18a41e1ecd46ea603bcc5507210e252b

- Joseph Wu


On Aug. 1, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61308/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-7541
>     https://issues.apache.org/jira/browse/MESOS-7541
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch was generated with ZOOKEEPER-2841 and ZOOKEEPER-1643 (the
> original patch). This adds a CMake build system to ZooKeeper and fixes
> the Windows build. The exact patch lives at:
> 
> https://github.com/andschwa/zookeeper/tree/cmake-backport-3.4.8
> 
> Note that the deletion of the .sln file was removed in comparison to the
> PR to backport these patches to ZooKeeper's 3.4 branch. This is because
> the file is committed with CRLF line endings, but the generated patch
> does not include them. This confuses GNU Patch, and the easiest solution
> was to ignore the deletion of the file.
> 
> When PR #313 is accepted to ZooKeeper and the next patch version of 3.4
> is released, we can replace the tarball and delete this patch.
> 
> 
> Diffs
> -----
> 
>   3rdparty/zookeeper-3.4.8.patch 486df1ae96af3426835c9d47ff2e36dd47ccde3f 
> 
> 
> Diff: https://reviews.apache.org/r/61308/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message