mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic.
Date Sat, 02 Sep 2017 03:16:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62051/
-----------------------------------------------------------

(Updated Sept. 2, 2017, 3:16 a.m.)


Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Joseph Wu.


Changes
-------

Documented another case based on jie's analysis.


Repository: mesos


Description (updated)
-------

This updates the comments to include my findings after having looked
into using BEV_EVENT_READING / BEV_EVENT_WRITING to handle read and
write path errors separately. Unfortunately, we cannot do this using
libevent 2.0.x (see the comments).

This also clarifies the "dirty" SSL shutdown case and the case where
futher sends are performed on a shut down socket.


Diffs (updated)
-----

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 0fa7565d1dc49e53890708df154c4d8ea278ad37



Diff: https://reviews.apache.org/r/62051/diff/2/

Changes: https://reviews.apache.org/r/62051/diff/1-2/


Testing
-------

N/A


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message